Skip to content

Commit

Permalink
fix: Add "Tested with" before Ubuntu version in kernel crash dump OS …
Browse files Browse the repository at this point in the history
…requirement tooltips (#5558)

- Tooltips showing the minimum Ubuntu version for enabling kernel crash dumps now say "Tested with" before the version number.
  • Loading branch information
ndv99 authored Dec 5, 2024
1 parent 6f4d066 commit 0a7f880
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -726,7 +726,7 @@ describe("DeployFormFields", () => {

await waitFor(() => {
expect(screen.getByRole("tooltip")).toHaveTextContent(
"Ubuntu 24.04 LTS or higher."
"Tested with Ubuntu 24.04 LTS or higher."
);
});
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -291,13 +291,15 @@ export const DeployFormFields = (): JSX.Element => {
</span>
}
/>{" "}
and OS{" "}
must meet the minimum requirements and the OS{" "}
<TooltipButton
iconName="help-mid-dark"
message="Ubuntu 24.04 LTS or higher."
message="Tested with Ubuntu 24.04 LTS or higher."
/>{" "}
must meet the minimum requirements and secure boot must be
disabled. Check crash dump status in machine details.
must support it. Check crash dump status in machine details.{" "}
<ExternalLink to="https://ubuntu.com/server/docs/kernel-crash-dump">
More about kernel crash dump
</ExternalLink>
</>
}
label={
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ describe("KernelParametersForm", () => {

await waitFor(() => {
expect(screen.getByRole("tooltip")).toHaveTextContent(
"Ubuntu 24.04 LTS or higher."
"Tested with Ubuntu 24.04 LTS or higher."
);
});
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,13 +86,12 @@ const KernelParametersForm = (): JSX.Element => {
</span>
}
/>{" "}
and OS{" "}
must meet the minimum requirements and the OS{" "}
<TooltipButton
iconName="help-mid-dark"
message="Ubuntu 24.04 LTS or higher."
message="Tested with Ubuntu 24.04 LTS or higher."
/>{" "}
must meet the minimum requirements and secure boot must be disabled.
Check crash dump status in machine details.{" "}
must support it. Check crash dump status in machine details.{" "}
<ExternalLink to="https://ubuntu.com/server/docs/kernel-crash-dump">
More about kernel crash dump
</ExternalLink>
Expand Down

0 comments on commit 0a7f880

Please sign in to comment.