-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rockcraft.yaml for tensorboard-controller #29
base: main
Are you sure you want to change the base?
Add rockcraft.yaml for tensorboard-controller #29
Conversation
build-snaps: | ||
- go | ||
build-packages: | ||
- apt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can remove bash
and apt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK I will
- CGO_ENABLED: 0 | ||
- GOOS: linux | ||
stage-packages: | ||
- bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can remove bash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK I will
mkdir -p $CRAFT_PART_INSTALL/ | ||
cp manager $CRAFT_PART_INSTALL/ | ||
|
||
# security requirement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you put this into another part?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK I will add a security-team-requirement
part
1fa9f02
to
71cb352
Compare
No description provided.