Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rockcraft.yaml for tensorboard-controller #29

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

manolis-andr
Copy link

No description provided.

@manolis-andr manolis-andr requested a review from a team as a code owner July 24, 2023 17:15
build-snaps:
- go
build-packages:
- apt
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove bash and apt

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK I will

- CGO_ENABLED: 0
- GOOS: linux
stage-packages:
- bash
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove bash

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK I will

mkdir -p $CRAFT_PART_INSTALL/
cp manager $CRAFT_PART_INSTALL/

# security requirement
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you put this into another part?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK I will add a security-team-requirement part

@manolis-andr manolis-andr force-pushed the feature-tensorboard-controller branch from 1fa9f02 to 71cb352 Compare August 16, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants