Update links and image for 1.9.0 (#196)

* Update links and image for 1.9 * feat: update service command to use tini --------- Co-authored-by: Noha Ihab <[email protected]> Co-authored-by: NohaIhab <[email protected]>
canonical · Jul 5, 2024 · 6c99949 · 6c99949
1 parent 5711888
commit 6c99949
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/config.yaml b/config.yaml
@@ -40,7 +40,7 @@ options:
     description: Whether to enable the registration flow on sign-in
   menu-link-order:
     type: string
-    default: '["Notebooks", "Experiments (AutoML)", "Experiments (KFP)", "Pipelines", "Runs", "Recurring Runs", "Volumes", "Tensorboards"]'
+    default: '["Notebooks", "Katib Experiments", "Experiments (KFP)", "Pipelines", "Runs", "Recurring Runs", "Volumes", "TensorBoards"]'
     description: >
       YAML or JSON formatted list of strings defining the order of the menu links in the dashboard sidebar.  
       For usage details, see https://github.com/canonical/kubeflow-dashboard-operator.
@@ -52,7 +52,7 @@ options:
       For usage details, see https://github.com/canonical/kubeflow-dashboard-operator.
   quick-link-order:
     type: string
-    default: '["Upload a pipeline","View all pipeline runs","Create a new Notebook server","View Katib Experiments"]'
+    default: '["Create a new Notebook server", "Upload a Pipeline", "View Pipeline Runs"]'
     description: >
       YAML or JSON formatted list of strings defining the order of the quick links in the dashboard sidebar.  
       For usage details, see https://github.com/canonical/kubeflow-dashboard-operator.

diff --git a/metadata.yaml b/metadata.yaml
@@ -12,7 +12,8 @@ resources:
     type: oci-image
     description: 'Backing OCI image'
     auto-fetch: true
-    upstream-source: docker.io/kubeflownotebookswg/centraldashboard:v1.8.0
+    # On using the ROCK, modify the service command in the charm.py to remove tini
+    upstream-source: docker.io/kubeflownotebookswg/centraldashboard:v1.9.0-rc.1
 provides:
   links:
     interface: kubeflow_dashboard_links

diff --git a/src/charm.py b/src/charm.py
@@ -63,7 +63,10 @@ def __init__(self, *args):
         self._lightkube_field_manager = "lightkube"
         self._profiles_service = None
         self._name = self.model.app.name
-        self._service = "npm start"
+        # Remove tini when using the rock
+        # Uncomment when using the rock and remove the line below
+        # self._service = "npm start"
+        self._service = "/sbin/tini -- npm start"
         self._container_name = "kubeflow-dashboard"
         self._container = self.unit.get_container(self._name)
         self._configmap_name = self.model.config["dashboard-configmap"]