Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "set -xe" for exiting on errors #142

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

kimwnasptd
Copy link
Contributor

Refs canonical/bundle-kubeflow#1030

The current scanning action is failing because the bash script for gathering the image is failing, but the whole step is not failing
https://github.com/canonical/bundle-kubeflow/actions/runs/10482022617/job/29032456143#step:6:13

Error: open releases/1.9/stable/kubeflow/bundle.yaml: no such file or directory
Error: open releases/1.9/stable/kubeflow/bundle.yaml: no such file or directory
Image list:

This PR adds set -xe to all the bash scripts, to ensure they will exit if any of their sub-commands exits prematurely

Signed-off-by: Kimonas Sotirchos <[email protected]>
Copy link

@mvlassis mvlassis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposal looks good to me!

@kimwnasptd kimwnasptd merged commit 4a03052 into main Aug 23, 2024
4 checks passed
@kimwnasptd kimwnasptd deleted the kimwnasptd-bash-setxe branch August 23, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants