Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update send-scan.py with gh meta and verbosity #141

Merged
merged 6 commits into from
Aug 20, 2024
Merged

Update send-scan.py with gh meta and verbosity #141

merged 6 commits into from
Aug 20, 2024

Conversation

maci3jka
Copy link
Contributor

Added:

  • GitHub metadata to request - usefull when having multiple repos
  • Verbosity flag printing request body and response code

KU-1194

Update send-scan.py with gh meta and verbosity
80ed305 
Added:
* GitHub metadata to request - usefull when having multiple repos
* Verbosity flag printing request  body and response code

KU-1194
@maci3jka maci3jka requested a review from a team as a code owner August 16, 2024 07:43
DnPlas
DnPlas reviewed Aug 16, 2024
View reviewed changes
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maci3jka! Left some comments.

scripts/cve-reports/README.md Outdated Show resolved Hide resolved
scripts/cve-reports/README.md Outdated Show resolved Hide resolved
scripts/cve-reports/send-scan.py Outdated Show resolved Hide resolved
scripts/cve-reports/send-scan.py Outdated Show resolved Hide resolved
scripts/cve-reports/send-scan.py Outdated Show resolved Hide resolved
scripts/cve-reports/send-scan.py Outdated Show resolved Hide resolved
scripts/cve-reports/send-scan.py Outdated Show resolved Hide resolved
scripts/cve-reports/send-scan.py Outdated Show resolved Hide resolved
Maciek Golaszewski added 2 commits August 16, 2024 21:06
@maci3jka maci3jka requested a review from DnPlas August 17, 2024 03:38
DnPlas
DnPlas previously approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maci3jka ! Just a few nits that you can fix before committing.

scripts/cve-reports/send-scan.py Outdated Show resolved Hide resolved
@DnPlas
Apply suggestions from code review
425191a 
Co-authored-by: Daniela Plascencia <[email protected]>
@DnPlas DnPlas merged commit ee758d5 into canonical:main Aug 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DnPlas DnPlas DnPlas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maci3jka @DnPlas