Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply authorization policy in user namespace to allow istio traffic #356

Closed
wants to merge 2 commits into from

Conversation

NohaIhab
Copy link
Contributor

@NohaIhab NohaIhab commented Oct 24, 2023

closes canonical/notebook-operators#311 and #355

Testing

  1. deploy charmed kubeflow latest/edge
  2. refresh the kfp-profile-controller charm to the one from this PR
juju refresh kfp-profile-controller --channel=latest/edge/pr-356 
  1. log in to the dashboard and create a namespace
  2. check AuthorizationPolicy objects in the user's namespace, expect 2 objects:
kubectl get authorizationpolicies.security.istio.io -n admin
NAME                            AGE
ns-owner-access-istio-charmed   15s
ns-owner-access-istio           12s
  1. create a notebook and verify there are no 403 logs from the jupyter-controller container
  2. create a data passing pipeline and verify that you can download artifacts from pipeline steps

@NohaIhab NohaIhab requested a review from a team as a code owner October 24, 2023 09:37
@NohaIhab
Copy link
Contributor Author

closing in favour of #360 to point to branch 1.8-updates-dev-branch

@NohaIhab NohaIhab closed this Oct 25, 2023
@NohaIhab NohaIhab deleted the fix-apply-authorization-policy branch October 25, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

controllers.Culler logs 403 on a request to /api/kernels
1 participant