feat: get images on main #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Libraries: Out of sync
Libraries: OK
and removed
Libraries: Out of sync
labels
|
What about images in templates? Do we want to remove them from final list? |
|
@i-chvets do you refer to the images we wanted to get rid, documented in #132? In this case let's not block this PR on that (orthogonal) effort. We need the above for airgap to make sure we are gathering all images. Then we can have a follow-up one on how to remove the extra images, used in the templates |
18 tasks
|
@kimwnasptd Adding this to keep track:
|
i-chvets
approved these changes
Sep 5, 2023
github-actions
bot
added
Libraries: Out of sync
Libraries: OK
and removed
Libraries: OK
Libraries: Out of sync
labels
NohaIhab
added a commit
that referenced
this pull request
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #131
should be merged after #133