chore: replace tls lib v3 and cert handler with tls lib v4 #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guillaume Belanger <[email protected]>
Signed-off-by: Guillaume Belanger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Here we bump the TLS Certificates Library from
v3tov4. This change allows to completely get rid of theCertHandlerabstraction layer. This change is a courtesy of the Credentials Charm Engineering team.Rationale
The TLS Certificates Library
v4takes care of most of the heavy lifting related to TLS Certificates. This new version of the library includes:CertHandler existed purely because of missing feature in TLS library. Now that lib v4 takes care of all of the above, charm authors shouldn't need to import an additional abstraction layer.
Library Changes
Compatibility Notes
This new version of the library still uses the same version of the underlying charm relation interface, meaning that this charm here will remain compatible with the same TLS providers.
Reference
https://charmhub.io/tls-certificates-interface