fix: updated get-images script #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary of changes: - Updated get images script to dynamically extract Istio images
|
Run the commands one by one, and also the script. It's producing the following expected images $ ./tools/get-images.sh
docker.io/istio/pilot:1.17.3
docker.io/istio/proxyv2:1.17.3Good job! So now istio is out of the list of static images as well |
kimwnasptd
approved these changes
Sep 5, 2023
i-chvets
added a commit
that referenced
this pull request
Sep 25, 2023
Summary of changes: - Updated get images script to dynamically extract Istio images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to this issue for more details: canonical/bundle-kubeflow#679
Summary of changes: