fix: istio-pilot's handling of incomplete Gateway Services #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the handling of a gateway LoadBalancer service that does not have any ingress IPs. Previously, this could fail if the ingress attribute was None, such as when there is no LoadBalancer provider present in the cluster.
| @@ -822,11 +839,13 @@ def _get_address_from_loadbalancer(svc): | |||
| (str): The hostname or IP address of the LoadBalancer service | |||
| """ | |||
| ingresses = svc.status.loadBalancer.ingress | |||
|
|
|||
| # May happen due to the Kubernetes cluster not having a LoadBalancer provider | |||
| if ingresses is None or len(ingresses) == 0: | |||
There was a problem hiding this comment.
?
Suggested change
| if ingresses is None or len(ingresses) == 0: | |
| if not ingresses: |
beliaev-maksim
suggested changes
May 23, 2023
| @@ -647,7 +664,7 @@ def _report_handled_errors(self, errors): | |||
| ) | |||
| self._log_and_set_status(status_to_publish) | |||
| for i, error in enumerate(errors): | |||
| self.log.info(f"Handled error {i}/{len(errors)}: {error.status}") | |||
| self.log.info(f"Handled error {i+1}/{len(errors)}: {error.status}") | |||
There was a problem hiding this comment.
you can use enumerate(errors, start=1)
Suggested change
| self.log.info(f"Handled error {i+1}/{len(errors)}: {error.status}") | |
| self.log.info(f"Handled error {i}/{len(errors)}: {error.status}") |
43 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the handling of a gateway LoadBalancer service that does not have any ingress IPs. Previously, this could fail if the ingress attribute was None, such as when there is no LoadBalancer provider present in the cluster.
This also adds a check during reconcile which will raise an ErrorWithStatus when the Gateway Service is not ready.