Skip to content

Commit

Permalink
tests: remove public-url config and add dex-oidc-config relation (#489)
Browse files Browse the repository at this point in the history
The public-url configuration option has been replaced by
a relation between dex-auth and oidc-gatekeeper. Because of that,
configuring this option is not required anymore, and in fact if kept,
can cause errors as it won't be recognised by Juju anymore.
This commit removes the extra configuration from the integration tests.

Part of #487
  • Loading branch information
DnPlas authored Jul 31, 2024
1 parent 4fb213d commit d74befd
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions tests/test_bundle.py
Original file line number Diff line number Diff line change
Expand Up @@ -255,20 +255,19 @@ async def test_enable_ingress_auth(ops_test: OpsTest):
config={
"static-username": USERNAME,
"static-password": PASSWORD,
"public-url": regular_ingress_gateway_ip,
},
)

await ops_test.model.deploy(
OIDC_GATEKEEPER,
channel=OIDC_GATEKEEPER_CHANNEL,
trust=OIDC_GATEKEEPER_TRUST,
config={"public-url": regular_ingress_gateway_ip},
)

await ops_test.model.add_relation(f"{ISTIO_PILOT}:ingress", f"{DEX_AUTH}:ingress")
await ops_test.model.add_relation(f"{ISTIO_PILOT}:ingress", f"{OIDC_GATEKEEPER}:ingress")
await ops_test.model.add_relation(f"{OIDC_GATEKEEPER}:oidc-client", f"{DEX_AUTH}:oidc-client")
await ops_test.model.add_relation(f"{OIDC_GATEKEEPER}:dex-oidc-config", f"{DEX_AUTH}:dex-oidc-config")
await ops_test.model.add_relation(
f"{ISTIO_PILOT}:ingress-auth", f"{OIDC_GATEKEEPER}:ingress-auth"
)
Expand Down

0 comments on commit d74befd

Please sign in to comment.