Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the OIDC token and refresh token issue for device flow #10

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

wood-push-melon
Copy link

@wood-push-melon wood-push-melon commented Apr 11, 2024

This pull request tries to fix the followings:

  • Missing OIDC ID token issue
  • Missing refresh token issue

Note
This pull request needs the PR in Fosite to be merged first.

@wood-push-melon wood-push-melon force-pushed the IAM-830 branch 2 times, most recently from 1ee987b to 76627af Compare April 11, 2024 02:36
nsklikas
nsklikas previously approved these changes Apr 11, 2024
Copy link

@nsklikas nsklikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's wait for the fosite PR to be merged so that we can update go.mod and then merge this

@wood-push-melon wood-push-melon marked this pull request as ready for review April 13, 2024 00:20
@nsklikas nsklikas mentioned this pull request Apr 15, 2024
2 tasks
@wood-push-melon wood-push-melon merged commit ad85d3c into canonical Apr 15, 2024
24 checks passed
@wood-push-melon wood-push-melon deleted the IAM-830 branch April 15, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants