check for non-availability of EFI variables #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops - we should close PRs here. Can we move this to launchpad? |
xypron
force-pushed
the
noefivar
branch
2 times, most recently
from
695d662
to
db8f452
Compare
Provide a function to determine if UEFI variable can be written. Signed-off-by: Heinrich Schuchardt <[email protected]>
Some UEFI firmware does not support EFI variables at runtime. In this case directory /sys/firmware/efi/efivars does not exist. This would lead to an exception when calling efibootmgr. Signed-off-by: Heinrich Schuchardt <[email protected]>
In the GRUB install test mock a writable efivars directory. Signed-off-by: Heinrich Schuchardt <[email protected]>
Some UEFI firmware does not support EFI variables at runtime. In this case directory /sys/firmware/efi/efivars does not exist. This would lead to an exception when calling efibootmgr. Signed-off-by: Heinrich Schuchardt <[email protected]>
In test_chrootable_target_default_mounts_uefi() mock a writable efivars directory. Signed-off-by: Heinrich Schuchardt <[email protected]>
A system may be booted via UEFI but not provide EFI variables at runtime. In this case directory /sys/firmware/efi exists but directory /sys/firmware/efi/efivars does not exist. We should not try to mount the non-existent directory. This implies that we should not add an efibootmgr command in gen_uefi_install_commands(). Suggested-by: Dan Bungert <[email protected]> Signed-off-by: Heinrich Schuchardt <[email protected]>
Some UEFI firmware does not support EFI variables at runtime. In this case directory /sys/firmware/efi/efivars does not exist. This would lead to an exception when calling efibootmgr. Signed-off-by: Heinrich Schuchardt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some UEFI firmware does not support EFI variables at runtime.
In this case directory /sys/firmware/efi/efivars does not exist.
This would lead to an exception when calling efibootmgr.
(LP: #2003222)