Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(ant,maven): add labels for description #916

Merged
merged 5 commits into from
Dec 4, 2024

Conversation

vpa1977
Copy link
Contributor

@vpa1977 vpa1977 commented Dec 1, 2024

Ant and maven plugin descriptions are overriden by rockcraft. Add labels to simplify documentation override.

  • Have you signed the CLA?

Ant and maven plugin descriptions are overriden by rockcraft.
Add labels to simplify documentation override.
@vpa1977
Copy link
Contributor Author

vpa1977 commented Dec 1, 2024

Note: ruff shows the following error:

craft_parts/executor/environment.py:276:5: PLC0206 Extracting value from dictionary without calling `.items()`
    |
274 |       )
275 |   
276 |       for key in data:
    |  _____^
277 | |         if not skip or key not in skip:
278 | |             data[key] = _replace_attr(data[key], replacements)
    | |______________________________________________________________^ PLC0[20](https://github.com/canonical/craft-parts/actions/runs/12108844086/job/33757305803?pr=916#step:7:21)6
    |

Found 1 error.
make: *** [Makefile:91: test-ruff] Error 1

Probably due to mutating the dictionary while iterating through the keys.

@vpa1977 vpa1977 marked this pull request as ready for review December 1, 2024 20:50
Reduce scope of description anchors in ant and maven
plugins to the post-build steps.
@mr-cal
Copy link
Contributor

mr-cal commented Dec 3, 2024

Note: ruff shows the following error:

craft_parts/executor/environment.py:276:5: PLC0206 Extracting value from dictionary without calling `.items()`
    |
274 |       )
275 |   
276 |       for key in data:
    |  _____^
277 | |         if not skip or key not in skip:
278 | |             data[key] = _replace_attr(data[key], replacements)
    | |______________________________________________________________^ PLC0[20](https://github.com/canonical/craft-parts/actions/runs/12108844086/job/33757305803?pr=916#step:7:21)6
    |

Found 1 error.
make: *** [Makefile:91: test-ruff] Error 1

Probably due to mutating the dictionary while iterating through the keys.

Yep, I'll put up a PR to fix this unrelated failure whenever we come to an agreement in canonical/craft-application#580

@mr-cal
Copy link
Contributor

mr-cal commented Dec 3, 2024

Nevermind, Tiago already cleaned it up in https://github.com/canonical/craft-parts/pull/922/files

@tigarmo
Copy link
Contributor

tigarmo commented Dec 4, 2024

I'll update this branch and merge it once the linting fix is in main (later today)

@tigarmo tigarmo added the squash label Dec 4, 2024
@tigarmo tigarmo merged commit 33ca642 into canonical:main Dec 4, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants