ensure we use InternalIP or ExternalIP machine addresses #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make sure that we use an IP address for the microk8s join commands. This is done by filtering for addresses of type
InternalIP
orExternalIP
.Changes
getControlPlaneNodesToJoin
to group the list of control plane addresses by type, then return a list of addresses of the same type. The order of preference is defined asInternalIP
, thenExternalIP
. We return the first list of addresses that is not empty.[2]string
for the join addresses, but rather return the full slice of found addresses.20-microk8s-join.sh
script to accept any number of join urls, not hardcoded to two.