Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub metadata for repo/branches in 1.9 #1039

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Add GitHub metadata for repo/branches in 1.9 #1039

merged 1 commit into from
Sep 2, 2024

Conversation

kimwnasptd
Copy link
Contributor

Closes #1037

@kimwnasptd kimwnasptd requested a review from a team as a code owner August 23, 2024 15:39
NohaIhab
NohaIhab reviewed Aug 30, 2024
View reviewed changes
Copy link
Contributor

@NohaIhab NohaIhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundle.yaml lgtm
I noticed that for resource-dispatcher the branch is hardcoded in https://github.com/canonical/bundle-kubeflow/blob/main/scripts/airgapped/get-all-images.sh#L14. Does it make sense to change it as part of this PR?

@kimwnasptd
Copy link
Contributor Author

@NohaIhab what I'm missing is why we have only the resource-dispatcher in this script and not MLflow charms/bundle.

In any case though I'd suggest that we also track this change as part of the PR that updates the image gathering script #1038

WDYT?

NohaIhab
NohaIhab previously approved these changes Sep 2, 2024
View reviewed changes
@kimwnasptd kimwnasptd force-pushed the KF-6147-update-repo-bundle-metadata branch from 0ab733f to b0091a2 Compare September 2, 2024 10:40
@kimwnasptd kimwnasptd force-pushed the KF-6147-update-repo-bundle-metadata branch from b0091a2 to 1eaa512 Compare September 2, 2024 10:41
@kimwnasptd kimwnasptd force-pushed the KF-6147-update-repo-bundle-metadata branch from 1eaa512 to 6224e17 Compare September 2, 2024 10:43
@kimwnasptd kimwnasptd merged commit 9db4dd1 into main Sep 2, 2024
@kimwnasptd kimwnasptd deleted the KF-6147-update-repo-bundle-metadata branch September 2, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NohaIhab NohaIhab NohaIhab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bundle for 1.9 is missing the branch gh metadata
2 participants
@kimwnasptd @NohaIhab