-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image scanning script logic is duplicated #1036
Comments
Thank you for reporting us your feedback! The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-6146.
|
The script also is written in bash, and without The common script should be converted to Python to make sure it's maintainable in the long run and has good programming practices. |
Writing here the main flow of the logic for gathering all the images. The main point to keep in mind is that the input to the scripts is a bundle file and this bundle can include both charms that are owned by the Analytics team and from other teams (i.e. MySQL). Then the flow of the script looks like the following:
|
Bug Description
This is part of #1032
Right now we have and use logic for gathering images for a bundle in 2 different places:
kubeflow-ci
This creates duplication of logic while in the end we should have one script for the logic.
The main difference is that the airgap script will need to add some extra charms/images. But this could be easily added as some specialised logic with an
--airgap
flag to the same scriptTo Reproduce
Run the action for scanning and the airgap scripts
Environment
current
main
https://github.com/canonical/bundle-kubeflow/tree/b2269189231aea9a1c594def3bd92549ebb3ee0dRelevant Log Output
Additional Context
No response
The text was updated successfully, but these errors were encountered: