-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scanning scripts are not working for 1.9 #1032
Comments
Thank you for reporting us your feedback! The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-6142.
|
Then, while not directly related to ensuring the action is working, we also need to fix Knative image gathering logic to include rocks canonical/knative-operators#220 |
After resolving canonical/knative-operators#219 the next error we see is the following (after setting + git clone --branch main https://github.com/canonical/kubeflow-roles-operator
Cloning into 'kubeflow-roles-operator'...
remote: Enumerating objects: 502, done.
remote: Counting objects: 100% (226/226), done.
remote: Compressing objects: 100% (114/114), done.
remote: Total 502 (delta 146), reused 152 (delta 112), pack-reused 276 (from 1)
Receiving objects: 100% (502/502), 120.49 KiB | 1.15 MiB/s, done.
Resolving deltas: 100% (262/262), done.
+ cd kubeflow-roles-operator
+ IMAGES+=($(bash ./tools/get-images.sh))
++ bash ./tools/get-images.sh
bash: ./tools/get-images.sh: No such file or directory This is because the
|
I resolved the above issue in the PR that refactors the code to use python scripts #1036 The script will ignore the roles that don't have images in them |
Closing this, since the final effort of #1036 is done. You can find an update action in |
Bug Description
Right now the action for scanning 1.9 is failing.
Currently the main reason is that an incorrect path is getting used, introduced by #1027. But we observed follow-up issues with the scanning like canonical/knative-operators#219.
The current list of bugs that need to be resolved around the scanning are:
You can see an initially failing scan (because of incorrect path) in
https://github.com/canonical/bundle-kubeflow/actions/runs/10500366253/job/29088636529
To Reproduce
Check the
Actions
tabEnvironment
current state of the repo as of 22 August 2024
Relevant Log Output
Additional Context
No response
The text was updated successfully, but these errors were encountered: