Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump 3.3.10 -> 3.4.16 #21

Merged
merged 2 commits into from
Jun 5, 2024
Merged

chore: bump 3.3.10 -> 3.4.16 #21

merged 2 commits into from
Jun 5, 2024

Conversation

DnPlas
Copy link
Contributor

@DnPlas DnPlas commented Jun 4, 2024 •
edited
Loading

Bump the rock to 3.4.16

Fixes #20

I made all changes based on this diff and the Dockerfile itself.

Testing the rock

  1. Build the rock rockcraft pack -v
  2. Copy the rock to a docker local registry sudo skopeo --insecure-policy copy oci-archive:<argo-rock-name>.rock docker-daemon:argoexec:0.1
  3. Run a container with the image, verify the workload runs correctly. You can exec into the container and run:
_daemon_@74a25ea68ce3:~$ argoexec version
argoexec: v3.4.16
  BuildDate: 2024-06-04T11:59:26Z
  GitCommit: 910a9aabce5de6568b54350c181a431f8263605a
  GitTreeState: clean
  GitTag: v3.4.16
  GoVersion: go1.20.14
  Compiler: gc
  Platform: linux/amd64

@DnPlas
chore: bump 3.3.10 -> 3.4.16
efb81be 
Bump the rock to 3.4.16

Fixes #20
@DnPlas DnPlas requested a review from a team as a code owner June 4, 2024 11:53
misohu
misohu reviewed Jun 5, 2024
View reviewed changes
Copy link
Member

@misohu misohu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments :)

argoexec/rockcraft.yaml Outdated Show resolved Hide resolved
argoexec/rockcraft.yaml Show resolved Hide resolved
argoexec/rockcraft.yaml Show resolved Hide resolved
argoexec/rockcraft.yaml Show resolved Hide resolved
argoexec/rockcraft.yaml Outdated Show resolved Hide resolved
argoexec/rockcraft.yaml Outdated Show resolved Hide resolved
misohu
misohu approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@misohu misohu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks Daniela

@DnPlas DnPlas merged commit ffcffa9 into main Jun 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misohu misohu misohu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update argoexec ROCK
2 participants
@DnPlas @misohu