Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove creation of mlpipeline_minio_artifact secret #133

Closed
wants to merge 10 commits into from

Conversation

DnPlas
Copy link
Contributor

@DnPlas DnPlas commented Sep 20, 2023

This secret should be created and managed by the kfp-profile-controller and not by the argo-controller operator.

TODO:

  • We may need kfp-profile-controller deployed in the integration tests for getting the removed Secret
  • Fix unit tests to match new number of applied resources
  • Do we need the object storage relation at all for argo-controller? - we do because of this

@DnPlas DnPlas requested a review from a team as a code owner September 20, 2023 12:05
@DnPlas DnPlas force-pushed the dnplas-remove-mlpipeline-secret branch from c176507 to b819122 Compare October 4, 2023 07:35
DnPlas added 4 commits October 4, 2023 14:16
This secret should be created and managed by the kfp-profile-controller
and not by the argo-controller operator.
@DnPlas DnPlas force-pushed the dnplas-remove-mlpipeline-secret branch from 3edc3cd to b7012ac Compare October 4, 2023 12:17
@DnPlas
Copy link
Contributor Author

DnPlas commented Oct 5, 2023

Closing in favour of #141

@DnPlas DnPlas closed this Oct 5, 2023
@DnPlas DnPlas deleted the dnplas-remove-mlpipeline-secret branch April 9, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant