-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update reference to image to point to rock #131
Conversation
Summary of changes: - Updated config.yaml to refer to published ROCK image instead of upstream container image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @i-chvets
If we approve and merge this PR, we would be reverting the argo 3.3.10 upgrades (we are now using the container image and CRDs 3.3.10). If we really want to integrate argo-controller with its corresponding rock, I suggest we first build and publish the newer version of the container image.
@DnPlas I don't understand. Currently, we have version 3.3.8 in We can postpone this work and move corresponding Jira to Blocked until we start doing 1.8 work for Seldon. @kimwnasptd What is your opinion on this? |
We have |
I see. #130 is not merged though. Anyway, let's bump it to 3.3.10. I will need to spin another version of the ROCK for this. |
…:canonical/argo-operators into kf-2351-feat-update-ref-to-argoexec-rock
@DnPlas Bumped version to 3.3.10. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @i-chvets, LGTM
Description
Integration of Argo Exec ROCK. Updating all required configuratoin files.
Summary of changes:
Testing
Related PRs:
canonical/argo-workflows-rocks#10