Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update reference to image to point to rock #131

Merged
merged 6 commits into from
Sep 20, 2023

Conversation

i-chvets
Copy link
Contributor

@i-chvets i-chvets commented Sep 14, 2023

Description

Integration of Argo Exec ROCK. Updating all required configuratoin files.

Summary of changes:

  • Updated config.yaml to refer to published ROCK image instead of upstream container image. Version of workload is 3.3.10.

Testing

Related PRs:
canonical/argo-workflows-rocks#10

Summary of changes:
- Updated config.yaml to refer to published ROCK image instead of
  upstream container image.
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @i-chvets

If we approve and merge this PR, we would be reverting the argo 3.3.10 upgrades (we are now using the container image and CRDs 3.3.10). If we really want to integrate argo-controller with its corresponding rock, I suggest we first build and publish the newer version of the container image.

@i-chvets
Copy link
Contributor Author

i-chvets commented Sep 15, 2023

Thanks @i-chvets

If we approve and merge this PR, we would be reverting the argo 3.3.10 upgrades (we are now using the container image and CRDs 3.3.10). If we really want to integrate argo-controller with its corresponding rock, I suggest we first build and publish the newer version of the container image.

@DnPlas I don't understand. Currently, we have version 3.3.8 in main and we are updating it to reference ROCK with the same version. What changes are being reverted by this PR exactly?

We can postpone this work and move corresponding Jira to Blocked until we start doing 1.8 work for Seldon. @kimwnasptd What is your opinion on this?

@DnPlas
Copy link
Contributor

DnPlas commented Sep 18, 2023

Thanks @i-chvets
If we approve and merge this PR, we would be reverting the argo 3.3.10 upgrades (we are now using the container image and CRDs 3.3.10). If we really want to integrate argo-controller with its corresponding rock, I suggest we first build and publish the newer version of the container image.

@DnPlas I don't understand. Currently, we have version 3.3.8 in main and we are updating it to reference ROCK with the same version. What changes are being reverted by this PR exactly?

We can postpone this work and move corresponding Jira to Blocked until we start doing 1.8 work for Seldon. @kimwnasptd What is your opinion on this?

We have argo-controller in 3.3.10 already, and argo-server will soon be on that version as well #130, if we merge this PR, we will be bringing back an older version of those components.

@i-chvets
Copy link
Contributor Author

We have argo-controller in 3.3.10 already, and argo-server will soon be on that version as well #130, if we merge this PR, we will be bringing back an older version of those components.

I see. #130 is not merged though. Anyway, let's bump it to 3.3.10. I will need to spin another version of the ROCK for this.

Ivan Chvets added 2 commits September 18, 2023 09:02
…:canonical/argo-operators into kf-2351-feat-update-ref-to-argoexec-rock
@i-chvets
Copy link
Contributor Author

@DnPlas Bumped version to 3.3.10.

Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @i-chvets, LGTM

@i-chvets i-chvets merged commit dba541a into main Sep 20, 2023
12 checks passed
@i-chvets i-chvets deleted the kf-2351-feat-update-ref-to-argoexec-rock branch September 20, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants