chore: bump argo-controller 3.3.10 -> 3.4 (#169)

* chore: bump argo-controller 3.3.10 -> 3.4

This commit bumps the oci-image to bring the 3.4 version, as well as
updates to the CRDs to their corresponding versions.

Fixes #166

charms/argo-controller/config.yaml

@@ -10,16 +10,9 @@ options:
     type: string
     default: "artifacts/{{workflow.name}}/{{workflow.creationTimestamp.Y}}/{{workflow.creationTimestamp.m}}/{{workflow.creationTimestamp.d}}/{{pod.name}}"
     description: S3 key prefix
-  executor:
-    type: string
-    default: emissary
-    description: |
-      Runtime executor for workflow containers. Defaults to `emissary` as it is the default in both Argo Workflows and
-      the upstream Kubeflow project. Cannot be `docker` on containerd, for a full list of executors, see:
-      https://argoproj.github.io/argo-workflows/workflow-executors/#workflow-executors
   executor-image:
     type: string
-    default: charmedkubeflow/argoexec:3.3.10-c88862f
+    default: gcr.io/ml-pipeline/argoexec:v3.4.16-license-compliance
     description: |
       Image to use for runtime executor. Should be updated alongside updating the rest of the charm's images.
   kubelet-insecure:

charms/argo-controller/metadata.yaml

@@ -12,7 +12,7 @@ resources:
     type: oci-image
     description: 'Backing OCI image'
     auto-fetch: true
-    upstream-source: argoproj/workflow-controller:v3.3.10
+    upstream-source: gcr.io/ml-pipeline/workflow-controller:v3.4.16-license-compliance
 containers:
   argo-controller:
     resource: oci-image

charms/argo-controller/src/charm.py

@@ -164,7 +164,6 @@ def _context_callable(self):
                 f"{self.object_storage_relation.component.get_data()['port']}"
             ),
             "kubelet_insecure": self.model.config["kubelet-insecure"],
-            "runtime_executor": self.model.config["executor"],
         }