Integration Tests for DBus Call RegisterWithActivationKeys #3486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage (computed on Fedora latest) •
|
jirihnidek
requested changes
Dec 20, 2024
|
|
||
| @pytest.mark.parametrize( | ||
| "wrong_case", ["wrong-act-key inside", "only wrong-act-key", "wrong-org", "wrong-act-key and wrong-org"] | ||
| ) |
There was a problem hiding this comment.
I would use several test_ methods for each wrong case. This is hard to understand.
There was a problem hiding this comment.
It seems that it would be hard to use this approach: https://github.com/candlepin/subscription-manager/blob/main/integration-tests/test_register.py#L110, because returned error message is different for each wrong case.
| @@ -42,7 +42,6 @@ EOF | |||
| ./integration-tests/scripts/run-local-candlepin.sh | |||
|
|
|||
| # create testing data in local candlepin | |||
| ./integration-tests/scripts/post-activation-keys.sh | |||
There was a problem hiding this comment.
This change should not be part of this PR. It is already part of another PR.
There was a problem hiding this comment.
ok, I will revert this change .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Card-ID: CCT-1051
see https://www.candlepinproject.org/docs/subscription-manager/dbus_objects.html
It is a DBus Method RegisterWithActivationKeys.
This PR covers happy path and wrong path for registering with activation keys.
There can be even wrong organization in a case with activation keys.
The method should provides a useful response when something wrong was used in arguments of the method.