-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.28] CCT-69: Anonymous registration #3383
Draft
m-horky
wants to merge
19
commits into
subscription-manager-1.28
Choose a base branch
from
mhorky/cct67-automatic-registration-1.28
base: subscription-manager-1.28
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[1.28] CCT-69: Anonymous registration #3383
m-horky
wants to merge
19
commits into
subscription-manager-1.28
from
mhorky/cct67-automatic-registration-1.28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-horky
force-pushed
the
mhorky/cct67-automatic-registration-1.28
branch
from
March 5, 2024 09:12
04025e4
to
7af3f9f
Compare
jirihnidek
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current code LGTM
m-horky
force-pushed
the
mhorky/cct67-automatic-registration-1.28
branch
from
June 6, 2024 07:50
7af3f9f
to
3fadb47
Compare
(Cherry picked from 4db4fd8)
(Cherry-picked from feea253)
* Card ID: CCT-67 (main branch) * Card ID: CCT-69 (backport) - /cloud/authorize?version=2: New - /consumers/{uuid}/certificates: Added 'Authorization' header (Cherry-picked from 43f57ca)
* Card ID: CCT-67 (main branch) * Card ID: CCT-69 (backport) The token we receive from Candlepin is valid for two days and should be kept even when the system is restarted. This cache files is used to make sure it persists. (Cherry-picked from ccc03e4)
* Card ID: CCT-67 (main branch) * Card ID: CCT-69 (backport) An abstraction managing anonymous entitlement certificates. (Cherry-picked from 23db3a4)
(Cherry-picked from 677a99c)
This patch creates a system for exit codes used by the worker. This way the C wrapper may be able to understand what happened inside of the application and alter its behavior. (Cherry-picked from f19eb00)
(Cherry-picked from 06c2fd2)
(Cherry-picked from 8d151e7)
* Card ID: CCT-67 (main branch) * Card ID: CCT-69 (backport) This patch implements the standard and anonymous flows for automatic cloud registration. (Cherry-picked from eba1a76)
* Card ID: CCT-67 (main branch) * Card ID: CCT-69 (backport) (Cherry-picked from b70aaf8)
* Card ID: CCT-67 (main branch) * Card ID: CCT-69 (backport) The delay was introduced in early versions of the code when Python was not reliable for long-running tasks. Since we want to make automatic registration in both standard and anonymous flow to be as fast as possible, this delay is removed. This splay period is now performed by the Python code in case the we have obtained the anonymous entitlement certificates; before we ask for the identity certificate. (Cherry-picked from cb18b79)
* Card ID: CCT-66 (main branch) * Card ID: CCT-67 (backport) During the first phase of anonymous cloud registration, the system has valid entitlement certificates that aren't associated with any consumer. We shouldn't be reporting missing identity. Previously this was an error state that was not valid, but with automatic registration it is possible to have a system consuming content that does not have an identity, for a transition period before it is part of an anonymous or claimed organization. (Cherry-picked from 4820e5f)
Originally fixed through ENT-5549, we need this patch in RHEL 8 as well. (Cherry-picked from bdb6a07)
Move the code that performs the waiting/delay during automatic registration in its own function; this way it can be reused also in other places. This is only a code recfatoring, there is no behaviour changes. (cherry picked from commit 85544b2)
The initial delay when performing the standard autoregistration used to be done directly in rhsmcertd (the C daemon). When the anonymous autoregistration was implemented, since it has to start immediately, that delay in rhsmcertd was dropped in favour of doing it "inline" during the autoregistration. The waiting was added only during the anonymous autoregistration flow and not during the standard autoregistration. Hence, add the autoregistration wait/delay before performing the standard autoregistration, restoring the previous behaviour. (cherry picked from commit 0d27a59)
ptoscano
force-pushed
the
mhorky/cct67-automatic-registration-1.28
branch
from
October 2, 2024 09:48
d691dc4
to
26e9d1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of few PRs into 1.28: