RHEL-9435: Get AWS metadata via IMDSv2 #3351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jirihnidek
requested changes
Nov 1, 2023
|
Yeah, I know about those. Working on it, I need to introduce some mocks. I know where the issues are. |
m-horky
force-pushed
the
mhorky/RHEL-9435_aws-imdsv2
branch
from
953f2df to
479fb5f
Compare
Coverage (computed on Fedora latest) •
|
||||||||||||||||||||||||||||||||||||||||
* Card ID: RHEL-9435 Even though both versions are officially supported, the AWS teams are tracking connections making v1 requests as WARNINGs [0]. This patch switches the order to try to use IMDSv2 first. [0]: https://github.com/aws/aws-imds-packet-analyzer
The function responsible for returning 'server' responses was altered to be less nested, which should improve its readability.
When type hints for 'dnf' are not available, loading this module would result in a test failure.
m-horky
force-pushed
the
mhorky/RHEL-9435_aws-imdsv2
branch
from
479fb5f to
c8b7cb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though both versions are officially supported, the AWS teams are tracking connections making v1 requests as WARNINGs 0.
This patch switches the order to try to use IMDSv2 first.