-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hostname printing in error messages #3343
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnsnyder
requested review from
a team and
jirihnidek
and removed request for
a team
October 10, 2023 14:09
I can still see the incorrectly formatted address: $ ((4e71f02ba...)) subscription-manager register --serverurl=[fe80::5]:1234/prefix
Unable to reach the server at fe80::5:1234/prefix See |
Use the existing helper to provide a properly formatted hostname for user displaying (e.g. for exception); this will fix the printing of IPv6 addresses. Turn the existing "host" member as property, so the current users keep working as expected.
Normalize the hostname printed for connection errors when pinging the server, in case anything was passed via --serverurl, --insecure, or --baseurl.
Ah, the joy of custom exception handling... fixed this one easily. |
ptoscano
changed the title
connection: normalize hostname in ConnectionOSErrorException
Fix hostname printing in error messages
Oct 11, 2023
ptoscano
force-pushed
the
ptoscano/fix-hostname-print-in-exception
branch
from
October 11, 2023 13:25
4e71f02
to
d045ae2
Compare
m-horky
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConnectionOSErrorException.host
to be a normalized hostnameExceptionMapper
These changes will fix the printing of IPv6 addresses in error messages.
Card ID: CCT-9