fix: adapt to the new state of insights-client.service on failure #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were recent changes to the insights-client.service systemd service of insights-client: RedHatInsights/insights-client#240 This in practice means that insights-client.service now automatically restarts itself in case of failure. Because of that, that the status of the service on failure now is not "failed" but "activating", since it will enabled again the next time insights-client.timer is triggered; the effect in the cockpit plugin is that the detection for a failed upload now does not work. To adapt to the new situation, tweak the detection a bit: in addition to the old logic (left there to support both old and new versions of insights-client), a new logic is added to check that the systemd service is "starting" (the cockpit mapping to the "activating" status) and its last result is different than "success" (hence it failed somehow). Also adapt the test a bit: the service needs explicit restarting now, rather than a "simple" start. Card ID: CCT-702
This was referenced Aug 27, 2024
|
This completely makes sense to me, thanks! I triggered a run against the new image in cockpit-project/bots#6775 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were recent changes to the insights-client.service systemd service of insights-client:
RedHatInsights/insights-client#240
This in practice means that
insights-client.servicenow automatically restarts itself in case of failure. Because of that, that the status of the service on failure now is not "failed" but "activating", since it will enabled again the next timeinsights-client.timeris triggered; the effect in the cockpit plugin is that the detection for a failed upload now does not work.To adapt to the new situation, tweak the detection a bit: in addition to the old logic (left there to support both old and new versions of insights-client), a new logic is added to check that the systemd service is "starting" (the cockpit mapping to the "activating" status) and its last result is different than "success" (hence it failed somehow).
Also adapt the test a bit: the service needs explicit restarting now, rather than a "simple" start.
Card ID: CCT-702