test: mock-insights: switch away from ssl.wrap_socket() #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssl.wrap_socket() is long deprecated, and dropped in Python 3.12. Switch to use an SSLContext for client authentication. Load also the system CA store, as it contains the Candlepin CA: this way, the CERT-based authentication (using the consumer certificate generated by Candlepin) can be validated.
ptoscano
force-pushed
the
ptoscano/tests-sslserver-fix
branch
from
9db9942 to
83c1616
Compare
ptoscano
changed the title
|
This LGTM, and should land either way. I triggered a rhel-10-0 run to validate this for cockpit-project/bots#6703 |
|
Green! 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ssl.wrap_socket()is long deprecated, and dropped in Python 3.12. Switch to use anSSLContextfor client authentication. Load also the system CA store, as it contains the Candlepin CA: this way, the CERT-based authentication (using the consumer certificate generated by Candlepin) can be validated.