feat: switch from .last-upload.results to .lastupload #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file /etc/insights-client/.last-upload.results is watched to determine when was the last upload done. A couple of important notes about it: 1) even though it is read (and parsed), its content is actually never used currently 2) the file is written by insights-client (better: insights-core) only when "legacy_upload" is true (which is the default as of this writing) While (1) is not much an issue, (2) means that the displaying of the last upload (timestamp) to Insights is not available when switching insights-client to non-legacy-upload. To avoid both the issues, switch from .last-upload.results to /etc/insights-client/.lastupload: - .lastupload is always written, no matter the mode, and its modification timestamp is indeed accurate - stop reading the file at all, saving a bit of resources There should be no behaviour changes.
|
The code is used to show the "Last upload to Insights" detail, which is checked by |
|
This looks fine, thanks! In the future you'll be able to get the stat information directly, but that requires a relatively new bridge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file
/etc/insights-client/.last-upload.resultsis watched to determine when was the last upload done. A couple of important notes about it:legacy_uploadis true (which is the default as of this writing)While (1) is not much an issue, (2) means that the displaying of the last upload (timestamp) to Insights is not available when switching insights-client to non-legacy-upload.
To avoid both the issues, switch from
.last-upload.resultsto/etc/insights-client/.lastupload:.lastuploadis always written, no matter the mode, and its modification timestamp is indeed accurateThere should be no behaviour changes.