Fix obsolete cockpit defer API #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
done/fail/always is the long-obsolete `cockpit.defer()` jQuery promise API, which will be dropped eventually. Replace them with the standard `Promise` API. This requires a little teak in safeDBusCall() -- while `.fail()` also returns the rejection, `Promise.catch()` handles it and returns nothing. In `InstalledProducts.handleAutoAttach()`, both handlers in were doing exactly the same thing, so use finally() instead. Also use an arrow instead of a function to avoid the `self = this` dance.
2 tasks
|
@ptoscano Can you please take a look? (Happy to talk you through the patch too, if you have questions). Thanks! |
ptoscano
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
done/fail/always is the long-obsolete
cockpit.defer()jQuery promise API, which will be dropped eventually. Replace them with the standardPromiseAPI.This requires a little teak in safeDBusCall() -- while
.fail()also returns the rejection,Promise.catch()handles it and returns nothing.In
InstalledProducts.handleAutoAttach(), both handlers in were doing exactly the same thing, so use finally() instead. Also use an arrow instead of a function to avoid theself = thisdance.