Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nueva versión de la página #42

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

mrsalitre
Copy link
Contributor

Con esta nueva versión solo hace falta rellenar un formulario para firmar el manifiesto. Ademas el resultado sigue siendo una pagina estática (aunque ahora sea dinámica), así que se puede alojar donde estaba la anterior.

Copy link
Member

@javiertoledo javiertoledo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this looks like a huge lot of added complexity just to have a form in the page, isn't it?

.gitignore Outdated Show resolved Hide resolved
.firebaserc Outdated Show resolved Hide resolved
.firebase/hosting.ZGlzdA.cache Show resolved Hide resolved
public/index.html Show resolved Hide resolved
src/components/HelloWorld.vue Show resolved Hide resolved
src/components/HelloWorld.vue Show resolved Hide resolved
src/components/LogOutBtn.vue Show resolved Hide resolved
src/store.js Show resolved Hide resolved
@javiertoledo
Copy link
Member

Also, the current page is being directly served from GitHub pages. The easiest way to make this version work with Github Pages would be to compile the static page to the docs directory instead of the default dist

mrsalitre and others added 2 commits June 16, 2019 15:10
Co-Authored-By: Javier Toledo <[email protected]>
Co-Authored-By: Javier Toledo <[email protected]>
@mrsalitre
Copy link
Contributor Author

It has more than just a form, the databases are reactive, and there is a control panel to manage new signatures. It is also a PWA installable with the idea that in the future the application grows, and we can put blogs, or mechanisms for job offers.

@javiertoledo
Copy link
Member

I saw that you deployed it to a new domain in firebase, so no need to keep serving it from GH Pages, I guess 😜 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants