Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1-language-links #385

Closed
wants to merge 12 commits into from
Closed

1-language-links #385

wants to merge 12 commits into from

Conversation

AnneSophieDumetz
Copy link
Collaborator

@AnneSophieDumetz AnneSophieDumetz commented Dec 20, 2023

1-language-links:
New section 7.2.2 gives direction on using brackets to add info about linked content (eg. when content is only in 1 language).
It incorporates former section 7.4 (now deleted); Section 7.5 renamed as 7.4 (links, section index updated)
LINKS:
Trello card
Pull Requests:
English PR
French PR
Previews:
English preview
French preview

…fo about links in 1 language and removing seciton 7.4 (integrated in 7.2.2
Copy link

netlify bot commented Dec 20, 2023

Deploy Preview for design-system-canada-ca ready!

Name Link
🔨 Latest commit e4734ed
🔍 Latest deploy log https://app.netlify.com/sites/design-system-canada-ca/deploys/659dd8bfb463c600098fce11
😎 Deploy Preview https://deploy-preview-385--design-system-canada-ca.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator Author

@AnneSophieDumetz AnneSophieDumetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1-language-links:
New section 7.2.2 gives direction on using brackets to add info about linked content (eg. when content is only in 1 language).
It incorporates former section 7.4 (now deleted

Trello card:
https://trello.com/c/ly9USoyy

French links:
canada-ca/systeme-conception#261

English PR: #385

preview: https://deploy-preview-385--design-system-canada-ca.netlify.app/style-guide/

french preview:
https://deploy-preview-261--systeme-conception-canada-ca.netlify.app/guide-redaction/

@AnneSophieDumetz AnneSophieDumetz changed the title update to section 7.2 --> added 7.2.2 on using brackets to specify info about links in 1 language and removing seciton 7.4 (integrated in 7.2.2 1-language-links (section 7.2 update) Dec 20, 2023
@AnneSophieDumetz AnneSophieDumetz changed the title 1-language-links (section 7.2 update) 1-language-links Dec 20, 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@delisma Do you know why this file is being promoted to the branch?

@AnneSophieDumetz
Copy link
Collaborator Author

@prycrane I made some update to the PR for both English and French -- mostly French was adjusted to match Design doc. That said, still need complete MR approval before it goes live :)

@AnneSophieDumetz AnneSophieDumetz marked this pull request as draft January 24, 2024 23:41
@AnneSophieDumetz AnneSophieDumetz deleted the 1-language-links branch January 24, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants