-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1-language-links #385
1-language-links #385
Conversation
…fo about links in 1 language and removing seciton 7.4 (integrated in 7.2.2
✅ Deploy Preview for design-system-canada-ca ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1-language-links:
New section 7.2.2 gives direction on using brackets to add info about linked content (eg. when content is only in 1 language).
It incorporates former section 7.4 (now deleted
Trello card:
https://trello.com/c/ly9USoyy
French links:
canada-ca/systeme-conception#261
English PR: #385
preview: https://deploy-preview-385--design-system-canada-ca.netlify.app/style-guide/
french preview:
https://deploy-preview-261--systeme-conception-canada-ca.netlify.app/guide-redaction/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@delisma Do you know why this file is being promoted to the branch?
Updated text in section 7.2.2
Updated code with language tags
- updated some formatting issues in 7.2.2 & updated date
@prycrane I made some update to the PR for both English and French -- mostly French was adjusted to match Design doc. That said, still need complete MR approval before it goes live :) |
1-language-links:
New section 7.2.2 gives direction on using brackets to add info about linked content (eg. when content is only in 1 language).
It incorporates former section 7.4 (now deleted); Section 7.5 renamed as 7.4 (links, section index updated)
LINKS:
Trello card
Pull Requests:
English PR
French PR
Previews:
English preview
French preview