Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix broken links in IA Spec #250

Merged
merged 13 commits into from
Jun 7, 2023
Merged

fix broken links in IA Spec #250

merged 13 commits into from
Jun 7, 2023

Conversation

jmealing
Copy link
Collaborator

@jmealing jmealing commented May 19, 2023 •
edited by prycrane
Loading

@netlify
Copy link

netlify bot commented May 19, 2023 •
edited
Loading

✅ Deploy Preview for design-system-canada-ca ready!

Name Link
🔨 Latest commit 0e933b1
🔍 Latest deploy log https://app.netlify.com/sites/design-system-canada-ca/deploys/647a3fc40401780008521dfc
😎 Deploy Preview https://deploy-preview-250--design-system-canada-ca.netlify.app/architecture/usage-canadaca-design
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jmealing jmealing mentioned this pull request May 19, 2023
Merged
@jmealing jmealing requested a review from delisma May 19, 2023 19:52
delisma
delisma approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@delisma delisma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approved. Waiting for the alternate language PR to be approved too.

@delisma delisma changed the title fix issue 249 fix broken links in IA Spec May 29, 2023
@prycrane
Copy link
Contributor

prycrane commented Jun 2, 2023

I fixed the alignment on canada-content-information-architecture-specification.html

@prycrane prycrane added the bug Something isn't working label Jun 5, 2023
@delisma delisma merged commit 02f9729 into master Jun 7, 2023
@delisma delisma deleted the fix-issue-249 branch June 7, 2023 12:45
delisma pushed a commit that referenced this pull request Jun 20, 2023
@jmealing
fix broken links in IA Spec (#250)
78a6300 
* fix issue 249

* Update mandatory-elements.md

* Update canada-content-information-architecture-specification.md

* Update canada-content-information-architecture-specification.md

* Update usage-canadaca-design.md

* Update mandatory-elements.md

* Update templates.md

* Update mandatory-elements.md

* Update organizing-content.md

* Update usage-canadaca-design.md

* Update mandatory-elements.md

* Update organizing-content.md

* Update usage-canadaca-design.md

---------

Co-authored-by: Peter Crane <[email protected]>
delisma pushed a commit that referenced this pull request Jun 23, 2023
@jmealing
fix broken links in IA Spec (#250)
f7b9c90 
* fix issue 249

* Update mandatory-elements.md

* Update canada-content-information-architecture-specification.md

* Update canada-content-information-architecture-specification.md

* Update usage-canadaca-design.md

* Update mandatory-elements.md

* Update templates.md

* Update mandatory-elements.md

* Update organizing-content.md

* Update usage-canadaca-design.md

* Update mandatory-elements.md

* Update organizing-content.md

* Update usage-canadaca-design.md

---------

Co-authored-by: Peter Crane <[email protected]>
@delisma delisma linked an issue Jun 23, 2023 that may be closed by this pull request
Links broken in IA Spec #249
Open
delisma pushed a commit that referenced this pull request Jun 26, 2023
@donohuech @LPipes4
@jmealing @LanaStewa
Update header material (#244)
1ab1208 
* Update global-header.html

* Update global-header.html

* Rename global-header.html to global-header.md

* Update breadcrumb-trail.html

* Update language-toggle.html

* Update global-header.md

* Update and rename search-box.html to search-box.md

* Update global-header.md

* Update and rename signature.html to signature.md

* Update and rename site-menu.html to site-menu.md

* Rename breadcrumb-trail.html to breadcrumb-trail.md

* Update global-header.md

* Update global-header.md

* Update global-header.md

* Add files via upload

* Add files via upload

* Delete 01-global-header-campaign-desktop-en.png

* Delete 01-global-header-campaign-small-en.png

* Delete 01-sign-in-mobile-en.jpg

* Delete 01-sign-in-desktop-en.jpg

* Delete 01-global-header-transactional-small-en.png

* Delete 01-global-header-transactional-desktop-en.png

* Update global-header.md

* Update breadcrumb-trail.md

* Add files via upload

* Add files via upload

* Update language-toggle.html

* Rename language-toggle.html to language-toggle.md

* Update search-box.md

* Add files via upload

* Update search-box.md

* Update signature.md

* Add files via upload

* Add files via upload

* Update site-menu.md

* Update global-header.md

Removed link to GCweb documentation

* Add files via upload

* Update language-toggle.md

* Update breadcrumb-trail.md

Removed a line of text, removed quick implementation guide

* Update language-toggle.md

Updated an image description and removed link to quick implementation guide

* Update search-box.md

Removed link to quick implementation guide

* Update signature.md

Removed link to GCWeb quick implementation

* Update site-menu.md

Removed GCWeb quick guide, updated blog link

* Update site-menu.md

Removed 'an entire theme' as per Peter's request

* Update breadcrumb-trail.md

* Update language-toggle.md

* Update search-box.md

* Update global-header.md

* Update signature.md

* Update site-menu.md

* Update global-header.md

Added cite tags

* Update breadcrumb-trail.md

Added cite tags

* Update language-toggle.md

Added cite tags

* Update search-box.md

Added cite tags

* Update signature.md

Added cite tags

* Update _config.yml

* Update _config.yml

* Update _config.yml

* Update _config.yml

* Update _config.yml

* Update _config.yml

* Update _config.yml

* Update _config.yml

* Update _config.yml

* Update global-header.md

* Update breadcrumb-trail.md

* Update language-toggle.md

* Update search-box.md

* Update signature.md

* Update site-menu.md

* Update site-menu.md

* Update _config.yml

* Update _config.yml

* Update _config.yml

* Update _config.yml

* Update _config.yml

* Update global-header.md

* Update site-menu.md

* Update breadcrumb-trail.md

* Update patterns-01-en.json

* Update global-header.md

* Update site-menu.md

Added a line: Links to the theme pages will remain available through the main band of the global footer and the breadcrumb trail.

* Update global-header.md

* Update _config.yml

* Update contextual-signin.html

Updated the pattern

* Update contextual-signin.html

Fixed bulleted list

* Update contextual-signin.html

Updated images

* Update breadcrumb-trail.md

Removed bulleted list

* Update signature.md

Removed bullets under content specs

* Update breadcrumb-trail.md

* Update signature.md

* Update contextual-signin.html
Update contextual-signin.html
Update contextual-signin.html
Update contextual-signin.html
Update contextual-signin.html
Update contextual-signin.html

* Update contextual-signin.html

* Add files via upload

* Update and rename contextual-signin.html to contextual-signin.md

* Add files via upload

* Update contextual-signin.md

* Add files via upload

* Delete 01a-signin-button-mobile-fr.png

* Create contextual-signin.md

* Update contextual-signin.md

* Delete contextual-signin.md

* Update search-box.md

* Update search-box.md

* Update contextual-signin.md

* Update contextual-signin.md

* Update contextual-signin.md

* Update breadcrumb-trail.md

* Update breadcrumb-trail.md

* Update breadcrumb-trail.md

* Update language-toggle.md

* Update search-box.md

* Update signature.md

* Update site-menu.md

* Update _config.yml

* Update _config.yml

* Update global-header.md

* Update breadcrumb-trail.md

* Update _config.yml

* Update _config.yml

* Update _config.yml

* Update _config.yml

* Update _config.yml

* Update _config.yml

* Update _config.yml

* Update _config.yml

* Update _config.yml

* Update _config.yml

* Update _config.yml

* Update _config.yml

* Update _config.yml

* Update _config.yml

* Update _config.yml

* Update default.html

* Update breadcrumb-trail.md

* Update contextual-signin.md

* Update contextual-signin.md

* Update global-header.md

* Update global-header files

* Migration: Content and Information Architecture Specification (#200)

* Create usage-canadaca-design.md

* Rename usage-canadaca-design.md to architecture/usage-canadaca-design-01.md

* Create usage-canadaca-design-02.md

* Update usage-canadaca-design-02.md

* Update usage-canadaca-design-02.md

* Update usage-canadaca-design-02.md

* Rename usage-canadaca-design-02.md to usage-canadaca-design-02.html

* Update usage-canadaca-design-02.html

* Update usage-canadaca-design-02.html

* Create template-en.md

* Update template-en.md

* Create usage-canadaca-design.md

* Update template-en.md

* Create mandatory-elements.md

* Create canada-content-information-architecture-specification.md

* Create organizing-content.md

* Create templates.md

* Update canada-content-information-architecture-specification.md

* Update usage-canadaca-design.md

* Update usage-canadaca-design.md

* Update mandatory-elements.md

* Update organizing-content.md

* Update templates.md

* Delete usage-canadaca-design-01.md

* Delete usage-canadaca-design-02.html

* Delete template-en.md

* Update canada-content-information-architecture-specification.md

* Update canada-content-information-architecture-specification.md

* Update mandatory-elements.md

* Update organizing-content.md

* Update templates.md

* Update usage-canadaca-design.md

* Update canada-content-information-architecture-specification.md

* Update mandatory-elements.md

* Update organizing-content.md

* Update templates.md

* Update usage-canadaca-design.md

* migration files

* Update canada-content-information-architecture-specification.md

* Update canada-content-information-architecture-specification.md

* Update mandatory-elements.md

* Update organizing-content.md

* Update templates.md

* Update usage-canadaca-design.md

* Update README.md

* Create m.md

* Add files via upload

* Delete m.md

* Update organizing-content.md

* Update organizing-content.md

* Update mandatory-elements.md

* Update templates.md

* Update usage-canadaca-design.md

* Delete conceptual-overview-fra.png

* Update mandatory-elements.md

* Update organizing-content.md

* Update templates.md

* Update usage-canadaca-design.md

* Update README.md

* Update README.md

* Update canada-content-information-architecture-specification.md

* Update _config.yml

Adding default breadcrumbs for architecture section

* Update _config.yml

Adding default breadcrumbs for architecture section

---------

Co-authored-by: David Elisma <[email protected]>

* Update site-footer-content.html (#245)

Fixing typo in the language toggle link which was giving a 404. No change needed on the French side, bc it is already working correctly

* Create contact-us

* Update contact-us/index.md

Co-authored-by: LPipes4 <[email protected]>

* Update contact-us/index.md

Co-authored-by: LPipes4 <[email protected]>

* Create contact-us

* Update templates.md (#248)

* fix links and tags

* Update templates.md

* Update support.md (#246)

Anchor links weren't working - possibly because there were capitals in the anchor??  Removed them.  

Only a problem on the english page.

* Update insights.md (#243)

Fixing a typo in the first on this page bullet

* fix broken links in IA Spec (#250)

* fix issue 249

* Update mandatory-elements.md

* Update canada-content-information-architecture-specification.md

* Update canada-content-information-architecture-specification.md

* Update usage-canadaca-design.md

* Update mandatory-elements.md

* Update templates.md

* Update mandatory-elements.md

* Update organizing-content.md

* Update usage-canadaca-design.md

* Update mandatory-elements.md

* Update organizing-content.md

* Update usage-canadaca-design.md

---------

Co-authored-by: Peter Crane <[email protected]>

* Update patterns-01-en.json

* Update patterns-01-en.json

* Update site-footer-contextual.html

Updated design specs

* Update site-footer-contextual.html

Updated footer specs

* Update site-footer-main.html

Updated footer specs

* Update site-footer-main.html

* Update site-footer-contextual.html

* update html

* Update theme-topic.html

* fix spacing

* fix mixed content

* Update labels.html

* fix broken feedback widget

* fixed broken images and removed problem classes

* Update latest-news.html

missing an s on http link

* Page was missing feedback submit script

* Fixed hidden character in date modified

* Added missing s in http

* added fontawesome link

* Update monitoring.html

Updating link to new TSS content

* added s to http

* added s to http

* Update .gitignore

* Update global-header.md

* Update breadcrumb-trail.md

* Update contextual-signin.md

* Update language-toggle.md

* Update search-box.md

* Update signature.md

* Update site-menu.md

* Update breadcrumb-trail.md

* Update contextual-signin.md

* Update language-toggle.md

* Update search-box.md

* Update signature.md

* Update site-menu.md

* Update breadcrumb-trail.md

* Update contextual-signin.md

* Update language-toggle.md

* Update search-box.md

* Update signature.md

* Update _config.ymal

---------

Co-authored-by: donohuech <[email protected]>
Co-authored-by: delisma <[email protected]>
Co-authored-by: Peter Smith <[email protected]>
Co-authored-by: LPipes4 <[email protected]>
Co-authored-by: Jennifer Mealing <[email protected]>
Co-authored-by: Lana Stewart <[email protected]>
Co-authored-by: Lana Stewart <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delisma delisma delisma approved these changes

Assignees

@donohuech donohuech

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Links broken in IA Spec
4 participants
@jmealing @prycrane @delisma @donohuech