refactor: remove migration application #2573
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisKujawa
requested review from
romansmirnov,
sdorokhova and
houssain-barouni
ChrisKujawa
changed the title
There was a problem hiding this comment.
In the failing CI, I still see migration container still referenced
Warning BackOff 4m59s (x69 over 19m) kubelet Back-off restarting failed container migration in pod integration-operate-7b966d5f99-dsxgr_camunda-pr-2573-intg-alpha-run-11859469969-sfx-2db799-upgrade(1462297a-83c5-4f30-aaeb-cafa5bf973fe)
Defaulted container "operate" out of: operate, migration (init)
Also operate templates were removed in #2554 by @aabouzaid
| @@ -41,33 +41,6 @@ spec: | |||
| imagePullSecrets: | |||
| [] | |||
| initContainers: | |||
There was a problem hiding this comment.
Suggested change
| initContainers: | |
| initContainers: | |
| [] |
|
So to me it looks like this PR is obsolete right? @houssain-barouni @aabouzaid there is no migration app as init container anymore in the core statefulset. |
|
@ChrisKujawa that's correct. No |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem does the PR fix?
Removes obsolete migration application. Was already removed here camunda/camunda#24620
What's in this PR?
Remove the config and init-container
Checklist
Please make sure to follow our Contributing Guide.
Before opening the PR:
make go.update-golden-only.After opening the PR: