-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: execution identity integration #2247
feat: execution identity integration #2247
Conversation
@aabouzaid can you double check this please? On the configmap, I wasn't sure about passing the camunda-platform-helm/charts/camunda-platform-alpha/templates/zeebe-gateway/deployment.yaml Lines 58 to 61 in cdea66b
For Camunda database configuration I saw we had this already in a few other configmaps I just left out the opensearch portion as the ask was only for elasticsearch. Let me know I can add it if needed. Also for the spring portion I just hard coded it as others have it set the same way. |
Hey Team @megglos @Ben-Sheppard Can you check to see if any other env vars are needed? camunda-platform-helm/charts/camunda-platform-alpha/templates/execution-identity/deployment.yaml Lines 51 to 62 in 0eec5d7
The ones requested in the main issue was added via configmap |
Hey @drodriguez-305 :).- Looking at the configuration added it seems like thats enough, until the recent license changes I've only ran the app with the config we shared in the main issue so should be good! To answer the other questions:
Thats fine for now, we will want OpenSearch at some point but we can add it later |
Can you please create a follow-up for adding opensearch support @drodriguez-305 ? |
1ee521d
to
a63c64c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you 👏
Which problem does the PR fix?
Related to #2195
This is the first iteration of adding Execution identity component to the clusters.
What's in this PR?
see related issue
Checklist
Please make sure to follow our Contributing Guide.
Before opening the PR:
make go.update-golden-only
.After opening the PR: