-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update modeling deps #4711
Update modeling deps #4711
Conversation
9a292ae
to
0eb28f0
Compare
9d7781e
to
d4bed88
Compare
This will also close #4590 |
0eb28f0
to
7257234
Compare
Right! |
a1e415c
to
a84b093
Compare
Required because of Carbon resetting <b> styles.
d4bed88
to
5254a40
Compare
Modeler freezes when I search for a whitespace: Screen.Recording.2024-11-21.at.13.54.54.mov |
@jarekdanielak great find 🏅 I was able to reproduce it; I think it is reasonable to ignore whitespace for the sake of searching, and whitespace only should not trigger a search (at all). Find the fix in bpmn-io/diagram-js#954, and as we're on it checkout bpmn-io/diagram-js#953, too. |
I'll integrate fixed versions of the dependencies shortly. |
I'll add linting to this PR so that we can close user task listeners too. |
Linting / user task listeners added via 77c84b1 |
BTW shouldn't we mention the search improvements in the general part of changelog? They affect dmn-js-drd partially. |
All bugs fixed ✔️, |
Verified user task listeners are in, too 🏁 |
Proposed Changes
Updates to
[email protected]
, addressing the following issues:Closes #4182
Closes #4658
Closes #4122
Closes #3439
Closes #4590
Highlight - Search ships with improved UX:
Prioritizing exact and start matches:
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/sr
toolCloses {LINK_TO_ISSUE}
orRelated to {LINK_TO_ISSUE}
Depends on #4620