Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify link-dependencies task #4611

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

barmac
Copy link
Collaborator

@barmac barmac commented Oct 16, 2024

Use yarn link without additional scripts for diagram-js and bpmn-js.

Proposed Changes

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

Use `yarn link` without additional scripts for diagram-js and bpmn-js.
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Oct 16, 2024
@nikku
Copy link
Member

nikku commented Oct 16, 2024

Any reason we still handle dmn-js and form-js differently?

@barmac
Copy link
Collaborator Author

barmac commented Oct 16, 2024

They are monorepos, so plain yarn link won't work there. We can probably improve linking of those libraries, but it's additional work.

@barmac barmac marked this pull request as ready for review October 16, 2024 09:59
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Oct 16, 2024
@barmac barmac requested review from a team, philippfromme and abdul99ahad and removed request for a team October 16, 2024 09:59
@barmac
Copy link
Collaborator Author

barmac commented Oct 16, 2024

One step at time :)

@barmac barmac merged commit 3186cff into develop Oct 16, 2024
22 checks passed
@barmac barmac deleted the simplify-link-dependencies branch October 16, 2024 11:47
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 16, 2024
@github-actions github-actions bot added this to the M82 milestone Oct 16, 2024
@nikku
Copy link
Member

nikku commented Oct 16, 2024

What I propose (instead of linking) is to facilitate npm override, using core (on board) facilities.

@barmac
Copy link
Collaborator Author

barmac commented Oct 16, 2024

Sure, we could try this out. Last time I checked I wasn't able to get it to work, but it was long time ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants