Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(EngineProfile): slightly re-word #4421

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

nikku
Copy link
Member

@nikku nikku commented Jul 4, 2024

Proposed Changes

I struggled to understand the original text ("unsupported version of what?"), so this is my attempt to simplify it:

Old

image

Proposed

image

Related to #2682

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jul 4, 2024
@nikku
Copy link
Member Author

nikku commented Jul 4, 2024

On a related note we don't warn at all, but rather force Camunda 8 as a diagram type if an unsupported executionPlatform is provided, i.e. activity. Is that intentional?

@nikku
Copy link
Member Author

nikku commented Jul 4, 2024

I did not address the download link issue (where I'd rather open the check update version, #4414 (comment)).

We can consider that in a future iteration, i.e. when working on #4407.

@nikku nikku requested review from marstamm, a team and barmac and removed request for a team July 4, 2024 13:36
@marstamm
Copy link
Member

marstamm commented Jul 4, 2024

On a related note we don't warn at all, but rather force Camunda 8 as a diagram type if an unsupported executionPlatform is provided, i.e. activity. Is that intentional?

Yes, this is was intentional and a "quick win" to open all valid BPMN diagrams. We could consider to add a warning similar to the DMN migration in a follow-up.
image

@nikku nikku merged commit c17a183 into develop Jul 4, 2024
12 checks passed
@nikku nikku deleted the propose-improved-unsupported-name branch July 4, 2024 13:55
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 4, 2024
@github-actions github-actions bot added this to the M79 milestone Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants