Get and Set Config for Files and Plugins #1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippfromme
changed the title
philippfromme
added
needs review
bpmn-io-tasks
nikku
reviewed
Sep 6, 2019
philippfromme
changed the title
philippfromme
changed the title
nikku
force-pushed
the
1066-config
branch
2 times, most recently
from
8213db8
to
cad89a2
Compare
nikku
previously requested changes
Sep 9, 2019
|
Test fail, please fix this. |
|
I've removed the bits in this PR that expose the tab via props to the extension. The way to access application state is via events. This is what we agreed upon to get out of the React propagation mess. 💯 |
|
@barmac Please take this PR over for review. |
|
Sure. |
philippfromme
force-pushed
the
1066-config
branch
3 times, most recently
from
52f2b39
to
21ca07d
Compare
philippfromme
dismissed
nikku’s stale review
@barmac is taking over the review
|
@barmac Ready to be reviewed |
barmac
reviewed
Sep 12, 2019
app/lib/file-system.js
Outdated
| @@ -8,8 +8,6 @@ | |||
| * except in compliance with the MIT License. | |||
| */ | |||
|
|
|||
| 'use strict'; | |||
There was a problem hiding this comment.
What's the reason of disabling strict mode?
There was a problem hiding this comment.
No need to do that:
- ES modules => Strict is default, no 'use strict' header
- NodeJS => Need 'use strict' header
Maybe there exists lint rules that can help us with keeping the the difference?
There was a problem hiding this comment.
To sum up, as the file is not an ES module, 'use strict'; should stay.
* unify ClientConfig and Config into Config * use <userPath>/config.json as default * add provider for custom functionality * add Client#getForFile, Client#setForFile, Client#getForPlugin and Client#setForPlugin * rename App#loadConfig to #getConfig Related to #1066
* file system is stateless, no class is needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App
Client
Related to #1066
Related to #1397
Closes #1425