Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter process instances by multiple variables and return bpmn groups, documentation, and extensionProperties in process details #496

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

HMubaireek
Copy link

Description

This PR adds the following features:

  • Allows filtering process instances by process variables:
{
  process(key: 2251799813712348){
    key
    processInstances(variablesFilter: {
      variables : [
      {
        name: "userEmail", 
        value:"[email protected]",
        comparisonOperation: EQUALS
      },
      {
        name: "processType", 
        value:"My Process Type",
        comparisonOperation: CONTAINS
      }          
      ],
      filterOperation: OR
    }
    ) {
      totalCount
      nodes {
        key
        variables(globalOnly: true){
           name
          value
        }
      }
    }
  }
}
  • Return documentation and extensionProperties along with process elements. In addition, allow returning bpmn:group elements since before it was only returning elements of type FlowElement
{
  process(key: 2251799813712348){
    key
    elements {
      elementId
      bpmnElementType
      extensionProperties {
        name
        value
      }
      documentation
    }
  }
}

Related issues

For filtering by variables:
closes # #16

For returning documentation, group, and extensionProperties:
closes # #356

@HMubaireek HMubaireek marked this pull request as draft May 6, 2024 09:59
@HMubaireek HMubaireek marked this pull request as ready for review May 6, 2024 10:06
@saig0 saig0 self-requested a review May 13, 2024 13:10
@saig0
Copy link
Contributor

saig0 commented May 13, 2024

@HMubaireek thank you for your contribution. 🎉 I'll have a look at the changes next week. 👀

Copy link
Contributor

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HMubaireek I did a quick review of your changes. Looks good in general. 🚀

I have concerns about the performance of the variables filtering and a few minor suggestions.

To speed up the review, please split up the changes into two PRs for the new BPMN element properties and the variables filtering. And, add some test cases to verify the behavior. 🍪


I'm sorry for the delay. Looking forward to the new features. ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants