-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: filter process instances by multiple variables and return bpmn groups, documentation, and extensionProperties in process details #496
base: main
Are you sure you want to change the base?
Conversation
…umentation for elements
feat: get process instances by variable name and value
…s-documentation-group-elements feat: return group elements, and return extension properties with documentation for elements
…le-variables feat: filter process instances by multiple variables
…le-variables feat: add filter operation to variables filter
…le-variables feat: add extensionElements to return properties and ioMapping
@HMubaireek thank you for your contribution. 🎉 I'll have a look at the changes next week. 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HMubaireek I did a quick review of your changes. Looks good in general. 🚀
I have concerns about the performance of the variables filtering and a few minor suggestions.
To speed up the review, please split up the changes into two PRs for the new BPMN element properties and the variables filtering. And, add some test cases to verify the behavior. 🍪
I'm sorry for the delay. Looking forward to the new features. ✨
Description
This PR adds the following features:
bpmn:group
elements since before it was only returning elements of type FlowElementRelated issues
For filtering by variables:
closes # #16
For returning documentation, group, and extensionProperties:
closes # #356