Adding possibility to throw an error on execution for CallActivityMocks #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Adding test for for throwing an error on execution
DavidEllermannIkor
force-pushed
the
master
branch
from
2c3ee76
to
4ac7c24
Compare
|
The change |
|
Thanks a lot for the contribution, I will have a look at it asap! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our team we switched to the camunda-platform-7-mockito library.
In addition, we wanted to improve our tests and tried to simulate activities that should trigger errors.
Regarding #267, I saw that this is currently not possible.
For our project I tried to create my own implementation of the CallActivityMock class with some modifications.
With these changes, I was able to run a JUnit 5 test that throws an error on the mocked activity.
I'm not sure now if the attached test is correct, but I've added an modified test for escalation so that an error is thrown
If this is an acceptable pull request, we'd love to see it included in a future release.