Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Configs #199

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

antonleviathan
Copy link
Contributor

Description

Refactor to use a mix of file and db stored config values

Related Issue

#197

Motivation and Context

This will make it easier to manage, specifically update, config values,

How Has This Been Tested?

TODO

Types of changes

  • Non-functional change (docs, style, minor refactor)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my code changes.
  • All new and existing tests passed.

@antonleviathan antonleviathan added the enhancement New feature or request label Feb 12, 2023
@antonleviathan antonleviathan marked this pull request as draft February 12, 2023 07:07
@coveralls
Copy link
Collaborator

coveralls commented Feb 12, 2023

Pull Request Test Coverage Report for Build 4184263694

  • 1 of 20 (5.0%) changed or added relevant lines in 2 files are covered.
  • 9 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 58.556%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/repositories/config-repository.ts 0 19 0.0%
Files with Coverage Reduction New Missed Lines %
src/handlers/request-handlers/root-request-handler.ts 9 13.79%
Totals Coverage Status
Change from base Build 4148256062: -0.4%
Covered Lines: 1168
Relevant Lines: 1971

💛 - Coveralls

seeds/initial-configs.js Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

3.8% 3.8% Coverage
15.5% 15.5% Duplication

seeds/configs.json Outdated Show resolved Hide resolved
seeds/initial-configs.js Outdated Show resolved Hide resolved
src/app/app.ts Outdated Show resolved Hide resolved
src/utils/settings.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants