-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic Configs #199
Draft
antonleviathan
wants to merge
7
commits into
main
Choose a base branch
from
197-request-dynamic-config-store-based-for-settings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Dynamic Configs #199
antonleviathan
wants to merge
7
commits into
main
from
197-request-dynamic-config-store-based-for-settings
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4184263694
💛 - Coveralls |
cameri
reviewed
Feb 15, 2023
SonarCloud Quality Gate failed. |
cameri
reviewed
Feb 19, 2023
cameri
reviewed
Feb 19, 2023
cameri
reviewed
Feb 20, 2023
cameri
reviewed
Feb 20, 2023
cameri
reviewed
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor to use a mix of file and db stored config values
Related Issue
#197
Motivation and Context
This will make it easier to manage, specifically update, config values,
How Has This Been Tested?
TODO
Types of changes
Checklist: