Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: NIP-42 #179

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: NIP-42 #179

wants to merge 10 commits into from

Conversation

antonleviathan
Copy link
Contributor

@antonleviathan antonleviathan commented Feb 6, 2023 •
edited
Loading

Description

Implements NIP-42

Related Issue

#162

How Has This Been Tested?

TODO

Types of changes

  • Non-functional change (docs, style, minor refactor)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my code changes.
  • All new and existing tests passed.

@antonleviathan antonleviathan requested a review from cameri February 6, 2023 19:01
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 4149542820

  • -29 of 118 (75.42%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.8%) to 59.845%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/handlers/event-strategies/auth-event-strategy.ts 17 18 94.44%
src/utils/event.ts 18 20 90.0%
src/adapters/web-socket-adapter.ts 21 29 72.41%
src/handlers/auth-event-message-handler.ts 22 40 55.0%
Totals Coverage Status
Change from base Build 4148256062: 0.8%
Covered Lines: 1253
Relevant Lines: 2066
💛 - Coveralls

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 4149542820

  • 89 of 118 (75.42%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.8%) to 59.845%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/handlers/event-strategies/auth-event-strategy.ts 17 18 94.44%
src/utils/event.ts 18 20 90.0%
src/adapters/web-socket-adapter.ts 21 29 72.41%
src/handlers/auth-event-message-handler.ts 22 40 55.0%
Totals Coverage Status
Change from base Build 4148256062: 0.8%
Covered Lines: 1253
Relevant Lines: 2066
💛 - Coveralls

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

74.4% 74.4% Coverage
9.9% 9.9% Duplication

@BANG88
Copy link

BANG88 commented Mar 8, 2023

Hello, any updates? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameri cameri cameri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@antonleviathan @coveralls @BANG88 @cameri