fix: confirm invoice confirmedAt is undefined (#320)

cameri · May 25, 2023 · e0e3a11 · e0e3a11
1 parent 7969701
commit e0e3a11
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/src/@types/services.ts b/src/@types/services.ts
@@ -11,7 +11,7 @@ export interface IPaymentsService {
   updateInvoice(invoice: Partial<Invoice>): Promise<void>
   updateInvoiceStatus(invoice: Pick<Invoice, 'id' | 'status'>): Promise<Invoice>
   confirmInvoice(
-    invoice: Pick<Invoice, 'id' | 'amountPaid' | 'confirmedAt'>,
+    invoice: Pick<Invoice, 'id' | 'amountPaid' | 'confirmedAt' | 'status' | 'pubkey'>,
   ): Promise<void>
   sendInvoiceUpdateNotification(invoice: Invoice): Promise<void>
   getPendingInvoices(): Promise<Invoice[]>

diff --git a/src/controllers/callbacks/opennode-callback-controller.ts b/src/controllers/callbacks/opennode-callback-controller.ts
@@ -51,6 +51,8 @@ export class OpenNodeCallbackController implements IController {
     try {
       await this.paymentsService.confirmInvoice({
         id: invoice.id,
+        pubkey: invoice.pubkey,
+        status: updatedInvoice.status,
         amountPaid: updatedInvoice.amountRequested,
         confirmedAt: updatedInvoice.confirmedAt,
       })

diff --git a/src/controllers/callbacks/zebedee-callback-controller.ts b/src/controllers/callbacks/zebedee-callback-controller.ts
@@ -70,11 +70,14 @@ export class ZebedeeCallbackController implements IController {
     }
 
     invoice.amountPaid = invoice.amountRequested
+    invoice.status = updatedInvoice.status
     updatedInvoice.amountPaid = invoice.amountRequested
 
     try {
       await this.paymentsService.confirmInvoice({
         id: invoice.id,
+        pubkey: invoice.pubkey,
+        status: invoice.status,
         confirmedAt: invoice.confirmedAt,
         amountPaid: invoice.amountRequested,
       })