Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed version to 0.10.0-alpha.1 #4

Merged
merged 2 commits into from
May 24, 2024
Merged

changed version to 0.10.0-alpha.1 #4

merged 2 commits into from
May 24, 2024

Conversation

Kevsy
Copy link
Contributor

@Kevsy Kevsy commented May 20, 2024

What type of PR is this?

Add one of the following kinds:

  • subproject management

What this PR does / why we need it:

First upload of YAML from previous Edge Cloud sub-project, incorporating the scope of Simple Edge Discovery for Fall 24 Release #3

Which issue(s) this PR fixes:

Fixes issue 3 (which will remain pinned/open as it relates to the release scope )

Special notes for reviewers:

Changelog input

 release-note
 Incorporates the changes listed in  #3 
 

Additional documentation

This section can be blank.

docs

@hdamker
Copy link
Contributor

hdamker commented May 21, 2024

@Kevsy two options here:

  1. This is already the PR which creates the alpha release. Then it should contain the CHANGELOG.md and the change to the README. Please add in the CHANGELOG also the link to the YAML within EdgeCloud (the exact commit which you have copied (I suppose that is https://github.com/camaraproject/EdgeCloud/blob/ed32560de80e55943d67766a040962df54d5498b/code/API_definitions/Discovery/simple_edge_discovery.yaml)
    In this case you have to set also the URL to simple-edge-discovery/v0.10alpha.1

  2. Recommend: you use this PR only to transfer the YAML and doing a release PR after some correction. Then the version both in version field and the URL would be "wip" for now.

default: https://localhost:443
description: API root.
basePath:
default: simple-edge-discovery/v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to be aligned with the version number.

example: 2001:db8:85a3:8d3:1319:8a2e:370:7344


###################################
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines are producing a linting error as they are not intended.

@Kevsy
Copy link
Contributor Author

Kevsy commented May 24, 2024

Thanks @hdamker ,

@Kevsy two options here:

  1. Recommend: you use this PR only to transfer the YAML and doing a release PR after some correction. Then the version both in version field and the URL would be "wip" for now.

Done

Need to be aligned with the version number.

Done

These lines are producing a linting error as they are not intended.

Done, removed

Also removed the release tag.

Copy link
Contributor

@javierlozallu javierlozallu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Perhaps you want to include the SED.test file since both files are in the Edge Cloud repository or do you want to wait for Commonalities 0.4 to upload all the necessary documents?

@Kevsy
Copy link
Contributor Author

Kevsy commented May 24, 2024

Looks good to me. Perhaps you want to include the SED.test file since both files are in the Edge Cloud repository or do you want to wait for Commonalities 0.4 to upload all the necessary documents?

Thanks @javierlozallu - I'll make a separate PR for that, and probably wait for the Commonalities v0.4 which will confirm the instructions in https://github.com/camaraproject/Commonalities/blob/main/documentation/API-Testing-Guidelines.md

@Kevsy Kevsy merged commit 7dd529d into main May 24, 2024
@Kevsy Kevsy deleted the Kevsy-patch-1 branch May 24, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants