-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed version to 0.10.0-alpha.1 #4
Conversation
@Kevsy two options here:
|
default: https://localhost:443 | ||
description: API root. | ||
basePath: | ||
default: simple-edge-discovery/v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to be aligned with the version number.
example: 2001:db8:85a3:8d3:1319:8a2e:370:7344 | ||
|
||
|
||
################################### |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lines are producing a linting error as they are not intended.
Thanks @hdamker ,
Done
Done
Done, removed Also removed the release tag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Perhaps you want to include the SED.test file since both files are in the Edge Cloud repository or do you want to wait for Commonalities 0.4 to upload all the necessary documents?
Thanks @javierlozallu - I'll make a separate PR for that, and probably wait for the Commonalities v0.4 which will confirm the instructions in https://github.com/camaraproject/Commonalities/blob/main/documentation/API-Testing-Guidelines.md |
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
First upload of YAML from previous Edge Cloud sub-project, incorporating the scope of Simple Edge Discovery for Fall 24 Release #3
Which issue(s) this PR fixes:
Fixes issue 3 (which will remain pinned/open as it relates to the release scope )
Special notes for reviewers:
Changelog input
Additional documentation
This section can be blank.