Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix x-correlator syntax #10

Merged
merged 4 commits into from
Jun 10, 2024
Merged

Fix x-correlator syntax #10

merged 4 commits into from
Jun 10, 2024

Conversation

Kevsy
Copy link
Contributor

@Kevsy Kevsy commented Jun 7, 2024

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

Align with Commonalities on syntax for x-correlator

Which issue(s) this PR fixes:

Fixes #8

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

Copy link

github-actions bot commented Jun 7, 2024

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.03s
❌ OPENAPI spectral 1 1 1.11s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY secretlint yes no 0.8s
✅ YAML yamllint 1 0 0.31s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Contributor

@javierlozallu javierlozallu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently there are some Linter errors

@Kevsy
Copy link
Contributor Author

Kevsy commented Jun 7, 2024

Fixed the errors reported earlier, and passed the local check: but the second Megalinter run says the Spectral ruleset itself is invalid...?

@Kevsy
Copy link
Contributor Author

Kevsy commented Jun 10, 2024

@javierlozallu my mistake (see issue #11) - please review PR #12 which will fix.

@javierlozallu javierlozallu merged commit ad9ef24 into main Jun 10, 2024
0 of 2 checks passed
@Kevsy Kevsy deleted the Kevsy-patch-3 branch June 11, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

X-Correlator -> x-correlator
2 participants