Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleEdgeDiscovery r1.1 release review #48

Closed
11 tasks done
tanjadegroot opened this issue Jul 24, 2024 · 2 comments
Closed
11 tasks done

SimpleEdgeDiscovery r1.1 release review #48

tanjadegroot opened this issue Jul 24, 2024 · 2 comments
Assignees
Labels
review Review of a proposed release (e.g. release PR)

Comments

@tanjadegroot
Copy link
Collaborator

tanjadegroot commented Jul 24, 2024

Related API issue or PR

camaraproject/SimpleEdgeDiscovery#32

Review actions

Assign this issue to yourself and follow the below list.
For any review action, review the file(s) in the issue/PR listed above.
Put comments in the above issue or PR if they concern non-changed files/text.
Put a short summary of the main review result here into the review issue.

  • API definition files (YAML) (check version in info & servers objects)
  • test file(s) availability
  • changelog updated
  • readme updated (enforce correct release number / API version naming)
  • API readiness checklist(s)

Release actions

Assign this issue to yourself or another RM team member and follow the below list.
When done, tick the box in this issue.

  • API release tracker available on wiki
  • Review comments addressed (by Sub Project)
  • Release PR approved (on behalf of Release Management)
  • PR merged (by Sub Project codeowner)
  • Release created within GitHub (by Sub Project codeowner)
  • Release Tracker updated (with creation date of the release and the release tag link)

Additional comments

@tanjadegroot tanjadegroot added the review Review of a proposed release (e.g. release PR) label Jul 24, 2024
@tanjadegroot tanjadegroot changed the title SimpleEdgeDiscovery rc.1 release review SimpleEdgeDiscovery M3 Fall24 release review Jul 25, 2024
@tanjadegroot tanjadegroot changed the title SimpleEdgeDiscovery M3 Fall24 release review SimpleEdgeDiscovery r1.1 release review Jul 25, 2024
@tanjadegroot tanjadegroot self-assigned this Jul 25, 2024
@tanjadegroot
Copy link
Collaborator Author

tanjadegroot commented Jul 26, 2024

Main review comments

  • clarify between release number and API version
  • Changelog updates accordingly
  • YAML: missing x-camara-commonalities
  • User Stories: remove Telco jargon
  • Readme update
  • switch to main branch '(no more release bracnches)

Approval to merge done.

@tanjadegroot
Copy link
Collaborator Author

First approved API release at M3 :-) Congratulations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Review of a proposed release (e.g. release PR)
Projects
None yet
Development

No branches or pull requests

1 participant