Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope of Simple Edge Discovery for Fall24 CAMARA release #3

Closed
Kevsy opened this issue May 20, 2024 · 16 comments
Closed

Scope of Simple Edge Discovery for Fall24 CAMARA release #3

Kevsy opened this issue May 20, 2024 · 16 comments
Labels
subproject management Issues and PRs related to the management of the sub project
Milestone

Comments

@Kevsy
Copy link
Contributor

Kevsy commented May 20, 2024

This issue shall define which issues are within scope of the API of the Simple Edge Discovery Sub Project for the Fall24 release, and will be regularly updated based on the decision within the EdgeCloud meetings.

Alignment with Commonalities 0.4 and ICM

Resource model name/structure changes aligned with EdgeCloud

Documentation

API Release Criteria

@Kevsy Kevsy added the subproject management Issues and PRs related to the management of the sub project label May 20, 2024
@Kevsy Kevsy pinned this issue May 20, 2024
@hdamker
Copy link
Contributor

hdamker commented May 20, 2024

@Kevsy would you like to transfer the issues from EdgeCloud into the SimpleEdgeDiscovery repository?

As you have write access to both repositories you can do it yourself, using the "Transfer issue" on the right column. Links to the previous location will be automatically redirected to the new location, so no problems with broken links in minutes etc.

@eric-murray
Copy link

@Kevsy
x-correlator is still defined with format: uuid in v0.11.0-rc.1, but Commonalities removed this restriction in v0.4.0. So x-correlator can now be any string.

@Kevsy
Copy link
Contributor Author

Kevsy commented Aug 7, 2024

@Kevsy x-correlator is still defined with format: uuid in v0.11.0-rc.1, but Commonalities removed this restriction in v0.4.0. So x-correlator can now be any string.

Thanks @eric-murray - raised in #33 for M4

@hdamker
Copy link
Contributor

hdamker commented Aug 16, 2024

@Kevsy don't forget the fix for #33

@Kevsy
Copy link
Contributor Author

Kevsy commented Aug 16, 2024

@Kevsy don't forget the fix for #33

Thanks - added to the scope above

@Kevsy Kevsy added this to the M4 milestone Aug 20, 2024
@Kevsy
Copy link
Contributor Author

Kevsy commented Aug 20, 2024

@hdamker
Copy link
Contributor

hdamker commented Aug 20, 2024

@Kevsy When creating the release PR for M4, please set the version therein to 1.0.0, not 0.11.0 -- assuming that you still consider to release a stable version. It would be great if you would also update the title and target version field on https://wiki.camaraproject.org/display/CAM/simple-edge-discovery+v0.11.0 already now to have a clear status there.

@Kevsy
Copy link
Contributor Author

Kevsy commented Aug 22, 2024

@Kevsy When creating the release PR for M4, please set the version therein to 1.0.0, not 0.11.0 -- assuming that you still consider to release a stable version.

Sure - just to clarify, you are not asking me to change the current PR #37 for v0.11.0-rc.2 - but rather to make sure the eventual release PR for M4 states uses v1.0.0 , correct?

It would be great if you would also update the title and target version field on https://wiki.camaraproject.org/display/CAM/simple-edge-discovery+v0.11.0 already now to have a clear status there.

Yes, I can change that now

@Kevsy
Copy link
Contributor Author

Kevsy commented Aug 22, 2024

@Kevsy When creating the release PR for M4, please set the version therein to 1.0.0, not 0.11.0 -- assuming that you still consider to release a stable version.

Sure @hdamker - just to clarify, you are not asking me to change the current PR #37 for v0.11.0-rc.2 - but rather to make sure the eventual release PR for M4 states uses v1.0.0 , correct?

It would be great if you would also update the title and target version field on https://wiki.camaraproject.org/display/CAM/simple-edge-discovery+v0.11.0 already now to have a clear status there.

Yes, I can change that now

@hdamker
Copy link
Contributor

hdamker commented Aug 22, 2024

Sure @hdamker - just to clarify, you are not asking me to change the current PR #37 for v0.11.0-rc.2 - but rather to make sure the eventual release PR for M4 states uses v1.0.0 , correct?

Yes, correct. We should just get #37 merged soon, as the "eventual release PR for M4" is already due on Monday :-)

@Kevsy
Copy link
Contributor Author

Kevsy commented Aug 22, 2024

Thanks @hdamker - so I can merge #37 now, release with tag r1.2, and then prepare the release PR for M4 by the Monday deadline :)

@hdamker
Copy link
Contributor

hdamker commented Aug 22, 2024

Thanks @hdamker - so I can merge #37 now, release with tag r1.2, and then prepare the release PR for M4 by the Monday deadline :)

Unfortunately you have merged #37 without addressing my comment that the CHANGELOG need to be updated. A release tag without documenting the changes compared to r1.1 is not very useful.

Would you mind to do another short PR with the CHANGELOG update before you create the r1.2 with the 0.11.0-rc.2 API version?

@hdamker
Copy link
Contributor

hdamker commented Aug 23, 2024

@Kevsy thanks for #38 ... so you are now ready to create the release with the r1.2 tag 👍

@Kevsy
Copy link
Contributor Author

Kevsy commented Aug 23, 2024

@hdamker Thanks, my mistake 🤦‍♂️ - also thanks to @javierlozallu for the fast approval.

I will make the release and then prepare the PR for M4 per the instructions - Monday is a UK bank holiday so will get it done today...

@hdamker
Copy link
Contributor

hdamker commented Oct 1, 2024

@Kevsy I suppose that this issue is done and can be closed. Consider to start planning for Spring25 😄

@Kevsy
Copy link
Contributor Author

Kevsy commented Oct 1, 2024

Thanks Herbert and all the contributors for getting this issue closed :)

@Kevsy Kevsy closed this as completed Oct 1, 2024
@JoseMConde JoseMConde unpinned this issue Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
subproject management Issues and PRs related to the management of the sub project
Projects
None yet
Development

No branches or pull requests

3 participants