[sim-swap-subscriptions]: remove allof in sinkcredential
#175
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfischer-tech
requested review from
bigludo7 and
fernandopradocabrillo
as code owners
dfischer-tech
changed the title
allof in sinkcredential
bigludo7
approved these changes
Nov 19, 2024
fernandopradocabrillo
added
the
don't merge
|
@fernandopradocabrillo This request is aligned with current commonalities rules (here line 299-300) so I guess we can merge it and have in r1.4. WDYT? |
Fine for me. It doesn't change the API functionality, just the structure of the schema so I don't think we need to update the API version. We can include it, I'll remove the don't merge tag |
fernandopradocabrillo
removed
the
don't merge
|
Hello @dfischer-tech I will then merge this one. It will be part of next release. |
bigludo7
requested changes
Dec 16, 2024
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Removing this
allOf.It was discovered for some code-generator, it will produce unexpected behaviours having the
descriptioninside theallOf.Which issue(s) this PR fixes:
Fixes #174
Changelog input