Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add management of monitoredPeriod in sim swap for retrieve-date operation #153

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
+35 −5
Open

Add management of monitoredPeriod in sim swap for retrieve-date operation #153

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7acbc2c
Update sim-swap.yaml
bigludo7 Sep 18, 2024
2c2ee5d
Update sim-swap.yaml
bigludo7 Sep 18, 2024
5b06115
Update sim-swap.yaml
bigludo7 Sep 18, 2024
dbe588b
Update sim-swap.yaml
bigludo7 Sep 20, 2024
9a4c2b3
Update code/API_definitions/sim-swap.yaml
bigludo7 Sep 30, 2024
d72cda6
Update sim-swap.yaml
bigludo7 Sep 30, 2024
c4b7288
Update code/API_definitions/sim-swap.yaml
bigludo7 Oct 3, 2024
649b471
Update .spectral.yml
bigludo7 Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions code/API_definitions/sim-swap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@ info:

- POST retrieve-date : Provides timestamp of latest SIM swap, if any, for a given phone number.

- If no swap has been performed, the API will return the SIM activation date (the timestamp of the first time that the SIM connected to the network).
- If no swap has been performed and the MNO supports unlimited SimSwap monitoring timeframe, the API will return the SIM activation date (the timestamp of the first time that the SIM connected to the network).
bigludo7 marked this conversation as resolved.
Show resolved Hide resolved

- If the latest SIM swap date (or the activation date if no SIM swap) cannot be communicated due to local regulations preventing the safekeeping of the information for longer than the stated period, a `null` value will be returned. Optionally, a `monitoredPeriod` could be provided to indicate that no SIM swap has occurred during this timeframe (in days).
- If the latest SIM swap date (or the activation date if no SIM swap) cannot be communicated due to local regulations (or MNO internal privacy policies) preventing the safekeeping of the information for longer than the stated period, a `null` value will be returned. Optionally, a `monitoredPeriod` could be provided to indicate monitored time frame (in days) supported by the MNO. In this case the response must be treated as "there was no sim swap events during 'monitoredPeriod'. Either the parameter is optional, it is recommended to support it in SimSwap implementations.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"there was no sim swap events" -> "there were no sim swap events"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed


- POST check: Checks if SIM swap has been performed during a past period (defined in the request with 'maxAge' attribute) for a given phone number.

Expand Down